I would say someone who can make the lesson interesting, i've had a few lessons that were so boring even i was bored never mind the poor horse (and i can get excited just passing a horse in a field

)
Also someone who is firm but not mean, who encourages you and gives you confidence. Pushes you to try things but also recognises when you've had enough. So slightly out your comfort zone but not terrified half to death!
I really like my RI. She isn't one for praise really, she always used to say at the end of group lessons 'you're all improving... slowly' was funny as she is quite serious!! She doesn't push us too hard but doesn't have sympathy for woosyness either.
The thing i like the most about her is the horsey mind reading she does... esp in the beginning when i was very nervous, it was like she would read my mind. I'd be on horsey thinking 'oh dear whats he looking at/why is he walking backwards/anything other than the norm' and she'd say without prompting 'oh he is just wanting to follow the others back to the stalls for breakfast' or 'he is just looking at that toilet door wondering if its about to open, push him on keep him busy'. I found this really helpful as saved me drumming up my own senario in th early days which would be something like 'oh no, he's going backwards, oh no oh no bet he's about to run off with me

'. I now know all the horses at the Rs and can now usually figure out for myself why they are doing A B or C!!
Also a sense of humour helps.
ANd not calling pupils names. Had a lesson recently where the instructor shouted throughout the whole lesson. It was so awful it was hilarious. It went along the lines of 'are you just going to sit on these ponies like a bunch of dumplins or are you going to ride them?' . The word 'dumplin' featured heavily throughout the lesson. There was a young girl behind me who cried the whole lesson. Now imo that RI could do with tweeking her teaching methods!!